abort signal support via regenerating on new openapigen commit #2583
+7
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
davidgamero
force-pushed
the
signal-support
branch
from
486d612 to
3d9b7d6
Compare
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
This was referenced Aug 13, 2025
Merged
k8s-ci-robot
added
needs-rebase
davidgamero
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
davidgamero
force-pushed
the
signal-support
branch
from
666e321 to
a789a30
Compare
k8s-ci-robot
added
needs-rebase
davidgamero
force-pushed
the
signal-support
branch
from
a789a30 to
1490801
Compare
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
size/S
mstruebing
reviewed
Aug 21, 2025
There was a problem hiding this comment.
Can you remove this part from the tsconfig-with-tests.json and tsconfig.json files?
"paths": {
"node-fetch/externals": ["./node_modules/@types/node-fetch/externals.d.ts"]
}https://github.com/kubernetes-client/javascript/blob/main/tsconfig-with-tests.json#L4-L8
https://github.com/kubernetes-client/javascript/blob/main/tsconfig.json#L20-L22
I think it should work without now.
yes done |
|
/lgtm Thanks 🚀 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidgamero, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses configuration timeout support from #2430 by allowing timeout signal into generated client code